[hue] Add new API support infrastructure#19309
Merged
jlaur merged 7 commits intoopenhab:mainfrom Sep 10, 2025
Merged
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds infrastructure support for new Philips Hue API features including motion detection, doorbell buttons, and speaker devices. The changes prepare the codebase for upcoming hardware releases by extending the resource type system and adding supporting DTOs.
- Extends the ResourceType enum with new resource types for upcoming devices
- Adds three new DTOs (Sound, SoundStatus, Mute) and three corresponding enums (SoundType, MuteType, SoftwareUpdateStatusType)
- Modifies the master Resource DTO to support new sound-related functionality and software update status tracking
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ResourceType.java | Adds new resource types for bell buttons, speakers, software updates, and other upcoming device categories |
| SoundType.java | Defines enum for various sound types used by doorbell and speaker devices |
| SoftwareUpdateStatusType.java | Defines enum for device software update status states |
| MuteType.java | Defines enum for sound mute/unmute states |
| SoundStatus.java | DTO for sound status information including current sound and available sound values |
| Sound.java | DTO for sound configuration with status and available sound values |
| Mute.java | DTO for mute state management |
| Resource.java | Extends master resource DTO to support new sound features and software update status with proper JSON element disambiguation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Sep 9, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks! Besides the failing tests and two minor comments, LGTM.
....openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/api/dto/clip2/Sound.java
Outdated
Show resolved
Hide resolved
...ab.binding.hue/src/main/java/org/openhab/binding/hue/internal/api/dto/clip2/SoundStatus.java
Outdated
Show resolved
Hide resolved
Contributor
|
The test failures are unrelated to your PR. |
…ing/hue/internal/api/dto/clip2/Sound.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…ing/hue/internal/api/dto/clip2/SoundStatus.java Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Contributor
Author
Do I need run maven with -DwithResolver ?? |
Contributor
I think it should be already handled by #19311. |
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As intimated in #19303 Philips / Signify is floating additional functionality. To be specific the following features are in the pipeline:
This PR is PHASE 1 which just adds the necessary infrastructure to support the above devices in future. It does the following:
ResourceTypeEnum to include the full list of known resource types.ResourceDTO to support these new DTOs and Enums .NOTE: this PR provides infrastructure only. The actual new channel-types will be added to the respective thing-types in a second phase once the actual new hardware goes on sale.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch